fix(parser): braced /{E1, E2} return-position effect row (Refs #59)#197
Merged
Conversation
The effects-migration-stance guide uses /{IO} and /{IO, Async} verbatim,
but only the bare single-term `-> T / E` and prefix `-{ E1 + E2 }->`
forms parsed; migrators could not write the documented syntax.
Adds `ARROW type_expr SLASH LBRACE sep_nonempty_list(COMMA, effect_term)
RBRACE`, folded into EffUnion via effect_union_of_list. The SLASH LBRACE
prefix is unambiguous (bare form continues on IDENT; prefix row uses
MINUS LBRACE; `{` cannot open a division operand in type position).
Conflict STATES unchanged (25 s/r, 5 r/r — the documented ADR-008/009
permissive class); the 35->36 r/r item is exactly what the ADR-008
note predicts for any SLASH production. dune test 253/253, zero
regression. Verified: /{IO} and /{IO, Async} parse+typecheck, /{IO,
Bogus} still rejected via the PR-1 registry, bare /IO unregressed.
Refs #59
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 18, 2026
🔍 Hypatia Security ScanFindings: 44 issues detected
View findings[
{
"reason": "Stray AI.a2ml in root -- use 0-AI-MANIFEST.a2ml only",
"type": "banned",
"file": "AI.a2ml",
"action": "delete",
"rule_module": "root_hygiene",
"severity": "high"
},
{
"reason": "Superseded by 0-AI-MANIFEST.a2ml",
"type": "banned",
"file": "AI.djot",
"action": "delete",
"rule_module": "root_hygiene",
"severity": "high"
},
{
"reason": "Issue in quality.yml",
"type": "missing_workflow",
"file": "quality.yml",
"action": "create",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Issue in security-policy.yml",
"type": "missing_workflow",
"file": "security-policy.yml",
"action": "create",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Action hyperpolymath/standards/.github/workflows/governance-reusable.yml@main needs attention",
"type": "unpinned_action",
"file": "governance.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "TypeScript file detected -- banned language",
"type": "banned_language_file",
"file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/example/smoke_driver.ts",
"action": "flag",
"rule_module": "cicd_rules",
"severity": "critical"
},
{
"reason": "TypeScript file detected -- banned language",
"type": "banned_language_file",
"file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/cli.ts",
"action": "flag",
"rule_module": "cicd_rules",
"severity": "critical"
},
{
"reason": "TypeScript file detected -- banned language",
"type": "banned_language_file",
"file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/mod.ts",
"action": "flag",
"rule_module": "cicd_rules",
"severity": "critical"
},
{
"reason": "TypeScript file detected -- banned language",
"type": "banned_language_file",
"file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/lib/compile.ts",
"action": "flag",
"rule_module": "cicd_rules",
"severity": "critical"
},
{
"reason": "TypeScript file detected -- banned language",
"type": "banned_language_file",
"file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/lib/runner.ts",
"action": "flag",
"rule_module": "cicd_rules",
"severity": "critical"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The
effects-migration-stanceguide uses/{IO}and/{IO, Async}verbatim as the migrator-facing syntax, but the grammar only parsed the bare single-term-> T / E(ADR-008) and the prefix-{ E1 + E2 }->row. So migrators could not write the documented syntax — flagged as out-of-scope follow-up in PR-1 (#196).Change (PR-2 of STAGE-B)
Adds one
return_typeproduction:ARROW type_expr SLASH LBRACE separated_nonempty_list(COMMA, effect_term) RBRACE, folded into the binaryEffUnionAST via a neweffect_union_of_listheader helper.The
SLASH LBRACEprefix is unambiguous: the bare form continues onIDENT, the prefix row usesMINUS LBRACE, and{cannot open a division operand in type position.Verification
SLASHproduction.dune buildclean;dune test --force253/253, zero regression./{IO}and/{IO, Async}now parse + typecheck;/{IO, Bogus}still rejected via the PR-1 registry (validation flows through the new form); bare/IOunregressed.Refs #59